New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed change to Cro::HTTP::CookieJar #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small things to change.
Here is where I got the idea of cloning the state, because this is done in add-from-response. This is also done on a newly created CookieState object. I just wanted to mention it, since you brought it up. |
|
@jnthn Is there anything blocking this addition of the |
|
@dolmen Forgot about this one; taking a quick look now, I think:
|
|
Things for merge:
Got it! |
|
This last commit should cover what's missing. Please review. |
|
Latest changes per jnthn's comments have been added. |
|
This last bit should clean up the indentation issues. Please review. |
1 similar comment
|
This last bit should clean up the indentation issues. Please review. |
This PR will add the ability to add Cro::HTTP::Cookies directly to any Cro::HTTP::CookieJar object.