Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename SSL to TLS #18

Closed
abraxxa opened this issue Sep 12, 2017 · 6 comments
Closed

rename SSL to TLS #18

abraxxa opened this issue Sep 12, 2017 · 6 comments

Comments

@abraxxa
Copy link
Contributor

abraxxa commented Sep 12, 2017

Because SSL up to version 3.0 is already deprecated by RFC7568 I'd suggest renaming all classes to TLS to reflect that it's new code which supports currently security standards.
I'd supply ;-) a pull-request if you want.

@jnthn
Copy link
Member

jnthn commented Sep 12, 2017

To be honest I've tended to use the two terms interchangeably when talking about the thing at a high level. :-) We could rename it, especially if it's going to make a better impression on people who know enough about the topic to be bothered/concerned by the name (which, given you created this issue, I guess some folks will). And if we don't take the chance now, it'll be hard to do it without much impact in the future.

Note that it really is using the TLS protocols by default. Renaming the IO::Socket::Async::SSL ecosystem module too is more churn than I think I care for, though... :-)

@abraxxa
Copy link
Contributor Author

abraxxa commented Sep 12, 2017

So does that mean you'd like a patch?
Yes I'm in the network security business and take such things seriously ;-)
What about alias classes for TLS which are recommended in the docs for new code and a soft deprecation for the old ones?

@jnthn
Copy link
Member

jnthn commented Sep 13, 2017

Let's:

  1. Create the cro-tls repository and push a renamed version of the module there, then get it into the module ecosystem
  2. Update everything downstream to use that instead
  3. Deprecate Cro::SSL (add is DEPRECATED trait) and then remove it a bit later

I've created cro-tls and given you push access there, so you won't need to PR that part. :-)

@abraxxa
Copy link
Contributor Author

abraxxa commented Sep 15, 2017

Pushed a modified cro-ssl to cro-tls.

@abraxxa
Copy link
Contributor Author

abraxxa commented Sep 15, 2017

Sent pull-requests for cro-http and cro.

@jnthn
Copy link
Member

jnthn commented Sep 15, 2017

Added Cro::TLS to the ecosystem, merged PRs. Thanks, @abraxxa 👍

@jnthn jnthn closed this as completed Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants