Repository navigation
Repro builds: Deterministically iterate through docker/ folder - #573
Merged
Merged
Conversation
Member
|
bors try |
Contributor
tryBuild succeeded: |
adamgreig
approved these changes
Jul 25, 2021
adamgreig
left a comment
adamgreig
left a comment
Member
There was a problem hiding this comment.
Thank you, and nice write-up too!
bors merge
Contributor
|
Build succeeded:
|
Contributor
Author
|
Thanks! Are there any plans for a new release? I've noticed there hasn't been one since about a year. :) |
Member
|
Yea, we'd like a new release (#542) but currently have a couple last blockers (and should ideally get a few more pending PRs merged...). The main issue is we're desperately low on maintainer time, since most of the rust-embedded team nominally responsible don't use cross or know much about it. I've just posted #574 with details of that. |
Alexhuszagh
added
meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the Arch Linux rebuilders has trouble reproducing the cross binary we distribute in Arch Linux. We assume this is because it runs a different filesystem than the official build server, causing
fs::read_dirto yield the directory content in a different order.This patch explicitly sorts the directory content of docker/ in build.rs before constructing a list that gets embedded in the binary.
Full writeup can be found over here: https://twitter.com/sn0int/status/1418254640324521997