Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Error Handling #416

Closed
cbleek opened this issue Sep 20, 2017 · 10 comments
Closed

Cleanup Error Handling #416

cbleek opened this issue Sep 20, 2017 · 10 comments

Comments

@cbleek
Copy link
Member

cbleek commented Sep 20, 2017

@fedys

I would like you to cleanup our error handling code. In #314 I've said, that we can do it later. We should do it now.

We're currently move all the code to ZF3. So you should do the Cleanup in the https://github.com/cross-solution/YAWIK/tree/feature/ZF3 Branch

@TiSiE can you shortly describe the task technically, please

@TiSiE
Copy link
Member

TiSiE commented Sep 20, 2017

It's pretty simple, actually. As said in #314, we do not want duplicate error handling, so we remove our error handling code and let tracy do its magic. Making it a mandatory requirement for YAWIK, not optional as it is now.

Which means, tracy should also display the error message screen in production mode, as well as log and email the error or fatal error. Of course, no error detail should be shown in production environments...

@fedys
Copy link
Collaborator

fedys commented Sep 20, 2017

@TiSiE Thanks for the clear instructions. I will take a look at it at the end of this week.

@fedys
Copy link
Collaborator

fedys commented Sep 21, 2017

I am working on it.

@TiSiE TiSiE assigned TiSiE and fedys and unassigned TiSiE Sep 21, 2017
@TiSiE TiSiE added this to the v0.30 milestone Sep 21, 2017
@cbleek
Copy link
Member Author

cbleek commented Oct 4, 2017

The Cleanup was done in fa8041c

So we can close this issue. Right?

@fedys
Copy link
Collaborator

fedys commented Oct 4, 2017

Yes.

@cbleek
Copy link
Member Author

cbleek commented Oct 4, 2017

OK.
But our documention is not correct any more
http://yawik.readthedocs.io/en/latest/modules/core/logging.html
http://yawik.readthedocs.io/en/latest/configuration.html#debugging

Can you update it, please?

@fedys
Copy link
Collaborator

fedys commented Oct 4, 2017

Yes, I can. I will let you know when I finish it.

@fedys
Copy link
Collaborator

fedys commented Oct 6, 2017

Done via the PR cross-solution/YawikDocs#2

@cbleek
Copy link
Member Author

cbleek commented Oct 6, 2017

Thank you

@cbleek cbleek closed this as completed Oct 6, 2017
@fedys
Copy link
Collaborator

fedys commented Oct 6, 2017

You are welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants