Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshots needs Statuses #437

Closed
TiSiE opened this issue Oct 10, 2017 · 5 comments
Closed

Snapshots needs Statuses #437

TiSiE opened this issue Oct 10, 2017 · 5 comments

Comments

@TiSiE
Copy link
Member

TiSiE commented Oct 10, 2017

We've implemented the ability to create snapshots of entities via:

and currenttly used in the Jobs module:

Snapshots (specifically the SnapshotMeta embedded document) is draftable to distinguish between active (unmerged) and merged snapshots.

As it is showing now, in the context of the jobs module, this is not enough. We need specific statuses of the snapshots to determine wether they were accepted, rejected, active.

So Snapshots needs to be State-Aware, which can be easily added with Core/StatusAwareInterface, Core/StatusAwareEntityTrait and the companion, Core/StatusInterface, respective Core/AbstractStatusEntity

What needs to be done:

  1. Make snapshots (at least the JobSnapshot entity) status-aware.
    This can be done by adding the status directly to the snapshot entity (overriding the status from the original entity - which must not be altered by the snapshot anyway) or in the SnapshotMeta document.
    (This needs to be discussed further)
  2. Make JobSnapshot Status entity with approppriate states
    • ACTIVE (UNMERGED)
    • ACCEPTED (MERGED)
    • REJECTED
  3. Set the respective status upon actions taken on the snapshot either by the recruiter or by the admin
  4. Show the current status in the recruiter's job list (and in the admin's job list)

Related classes to look at:

@TiSiE
Copy link
Member Author

TiSiE commented Oct 10, 2017

@kilip @fedys Whoever yells first may do this 😉

@cbleek
Copy link
Member

cbleek commented Oct 11, 2017

Hi @kilip

do you have time to do this task?

I'll need @fedis to do some final task concerning the SimpleImport module.

@cbleek
Copy link
Member

cbleek commented Oct 17, 2017

Hi @kilip

is the task description from TiSiE ok?

regards, carsten

@kilip
Copy link
Collaborator

kilip commented Nov 6, 2017

Hi @cbleek , @TiSiE
I start working on this issue now.

@TiSiE TiSiE assigned TiSiE and unassigned kilip Dec 5, 2017
@TiSiE
Copy link
Member Author

TiSiE commented Dec 5, 2017

@kilip Did you do anything yet? It would be nice to send a pull request, if so.... If not, you do not need to do anymore.

cross-bot pushed a commit that referenced this issue Dec 29, 2017
* Job snapshots are now status-aware by implementing StatusAwareInterface
* This state is changed according to actions by an admin or recruiter.
* States are shown as badges in the recruiters and admins job list, resp.
@TiSiE TiSiE removed the in progress label Dec 29, 2017
@TiSiE TiSiE closed this as completed Dec 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants