Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracy has been set as a default error/exception logger #416 #420

Merged
merged 1 commit into from Sep 22, 2017

Conversation

fedys
Copy link
Collaborator

@fedys fedys commented Sep 22, 2017

ErrorLogger has been completely removed with its related classes/configs
Tracy also includes an Exception markup as an attachment

ErrorLogger has been completely removed with its related classes/configs
Tracy also includes an Exception markup as an attachment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 37.799% when pulling fa8041c on fedys:issue/416 into c4ec29f on cross-solution:feature/ZF3.

@fedys
Copy link
Collaborator Author

fedys commented Sep 22, 2017

I tested the following scenarios:

  • production HTTP: notice, exception & fatal
  • production CLI: notice, exception & fatal
  • development HTTP: notice, exception & fatal
  • development CLI: notice, exception & fatal

I am not 100% sure about removed classes/configuration. I assume they are all related with the old ErrorLogger. Please check the removals carefully.

Consider the following idea. Create a single "System" logger which would replace multiple 'Core/Log' & 'Log/Core/Mail' loggers. This logger would have several writers attached. These writer would log messages into different locations depending of a message severity. For example, all messages would be written into yawik.log, severity above 'error' would be written into error.log and also send via Tracy email.

@fedys fedys changed the title Tracy has been set as a default error/exception logger Tracy has been set as a default error/exception logger #416 Sep 22, 2017
@TiSiE
Copy link
Member

TiSiE commented Sep 22, 2017

I don't grasp why we would need such a "System Logger", when tracy DOES log automatically into specific files in its log directory (as I understand). Don't get me wrong, such a Logger would be fancy indeed..

@cross-bot cross-bot merged commit fa8041c into cross-solution:feature/ZF3 Sep 22, 2017
cross-bot pushed a commit that referenced this pull request Sep 22, 2017
* pr-420:
  Tracy has been set as a default error/exception logger ErrorLogger has been completely removed with its related classes/configs Tracy also includes an Exception markup as an attachment
@fedys
Copy link
Collaborator Author

fedys commented Sep 22, 2017

@TiSiE See the following example where the System logger could be used to log to file and send email.

@fedys
Copy link
Collaborator Author

fedys commented Sep 22, 2017

@TiSiE In other words, the System logger could be used in cases when something unexpected happens but you do not want to let the application crash.

@fedys fedys deleted the issue/416 branch September 22, 2017 13:00
@TiSiE
Copy link
Member

TiSiE commented Sep 22, 2017

@fedys I see. We should keep that idea around!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants