Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #512 #521

Merged
merged 6 commits into from Nov 28, 2018
Merged

Issue #512 #521

merged 6 commits into from Nov 28, 2018

Conversation

@sergey-galenko
Copy link
Collaborator

sergey-galenko commented Nov 20, 2018

Not ready yet for review

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 20, 2018

Coverage Status

Coverage decreased (-0.2%) to 41.848% when pulling b9d6b0a on sergey-galenko:develop into 28c2996 on cross-solution:develop.

@TiSiE TiSiE self-assigned this Nov 21, 2018
Copy link
Collaborator Author

sergey-galenko left a comment

@TiSiE could you please point me in my sources why Salary entity is not saved into database after successful form data validation? I try to implement all the same way as for AtsMode entity without an extra code in module/Jobs/src/Controller/ManageController.php save method and module/Jobs/src/Controller/Plugin/InitializeJob.php plugin.

@sergey-galenko

This comment has been minimized.

Copy link
Collaborator Author

sergey-galenko commented Nov 23, 2018

@TiSiE thank you a lot! Do I have to write unit tests?

@cbleek

This comment has been minimized.

Copy link
Member

cbleek commented Nov 23, 2018

please make them later. I'm running out of my budget.

Maybe we can optimize one thing. I had noticed that you were also trying to figure out what was going on via "echo var_dump()".

Does debugging with breakpoints work in your PHP storm?

@sergey-galenko

This comment has been minimized.

Copy link
Collaborator Author

sergey-galenko commented Nov 23, 2018

no, I haven't used debugging with breakpoints in PHP storm. do you have some useful link for this?

@cbleek

This comment has been minimized.

Copy link
Member

cbleek commented Nov 23, 2018

@TiSiE will send you the needed infos

@sergey-galenko

This comment has been minimized.

Copy link
Collaborator Author

sergey-galenko commented Nov 23, 2018

ok. thank you a lot!

@TiSiE TiSiE changed the base branch from develop to release-0.32.0 Nov 28, 2018
@TiSiE TiSiE merged commit b9d6b0a into cross-solution:release-0.32.0 Nov 28, 2018
2 of 4 checks passed
2 of 4 checks passed
Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
coverage/coveralls Coverage decreased (-0.2%) to 41.848%
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
TiSiE added a commit that referenced this pull request Nov 28, 2018
* pr-521:
  [Jobs] Fixes: Salary data is not persisted
  Issue #512
  Issue #512
  Issue #512
  Issue #512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.