Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NettyWebSocket transport should not offer compression #503

Closed
om26er opened this issue Sep 16, 2020 · 1 comment · Fixed by #504
Closed

NettyWebSocket transport should not offer compression #503

om26er opened this issue Sep 16, 2020 · 1 comment · Fixed by #504

Comments

@om26er
Copy link
Contributor

om26er commented Sep 16, 2020

NettyWebSocket offers WebSocket compression, this seems to break our WAMP implementation. After the successful WebSocket handshake, no WAMP messages are delivered to the router.

This puts app code to state where it is stuck forever. The WebSocket ping/pong keeps working hence onDisconnect on the WAMP session side never gets called. Netty doesn't produce any errors at all.

This issue was spotted while trying to debug https://forum.crossbar.io/t/can-connect-but-not-join-to-crossbar-plain-java/1838

@oberstet
Copy link
Contributor

interesting. agree: for now, I think it's good enough to just deactivate compression. in general, I'd be curious what's the root cause / issue here (but I am confident the issue is more likely on nettys side - ABPy/CB is exhaustively tested for WS compression, and used with such eg from ABJS/browsers)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants