Send extra data while authentication #250

Merged
merged 1 commit into from Jan 11, 2017

Projects

None yet

3 participants

@Kolyunya
Contributor
Kolyunya commented Dec 7, 2016 edited

Fixes #249. This seems to be working just fine but I may be missing something.
Guy lets fix this please. This is a very important feature.

@jrocketfingers

I've encountered the same problem, and made the exact same corrections down to the letter before I noticed this PR. Can confirm it works.

@Kolyunya, have you had any luck actually building the library? I haven't worked with scons yet and I'm getting AttributeError: 'SConsEnvironment' object has no attribute 'JavaScript' when I try to run make build/make build_browser.

@Kolyunya
Contributor
Kolyunya commented Jan 7, 2017 edited

@jrocketfingers building guide is incomplete and outdated, I had very hard time building the library. I'll probably make a PR with new building instructions.

@jrocketfingers

I've already done the modifications manually, but thanks 👍 Looking forward to those build instructions.

By the way, since we're on the topic: I haven't utilized authrole just yet, but it seems to be an argument in ApplicationSession.join in autobahn-python. Would it make sense to pass it too? Perhaps if a single component could be authenticated for multiple roles it could represent the preferential role.

@Kolyunya
Contributor
Kolyunya commented Jan 8, 2017

@jrocketfingers yeah, it seems to me that 'authrole' may be useful while authentication too but it should be discussed in a separate issue.

@jrocketfingers

Are there any updates on this? I'd be alright if I could at least build the library.

@oberstet
Member

Sorry for sluggish responsive .. looks good! Thanks for contributing!

@oberstet oberstet merged commit 3976650 into crossbario:master Jan 11, 2017
@Kolyunya
Contributor

@oberstet can we please have a release? Thank you!

@oberstet
Member

The authrole is normally assigned automatically by the router when the authentication was successful. Generally, a WAMP client may also request a specific authrole, but the router might deny that or override it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment