New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced msgpack-lite with msgpack5 #330

Merged
merged 2 commits into from Nov 23, 2017

Conversation

Projects
None yet
2 participants
@agronholm
Contributor

agronholm commented Nov 23, 2017

This fixes subscription IDs being sent to the router as floats due to msgpack-lite's buggy handling of large numbers.

Replaced msgpack-lite with msgpack5
This fixes subscription IDs being sent to the router as floats due to
msgpack-lite's buggy handling of large numbers.
@oberstet

This comment has been minimized.

Show comment
Hide comment
@oberstet

oberstet Nov 23, 2017

Member

Does that work in browsers?

Member

oberstet commented Nov 23, 2017

Does that work in browsers?

@agronholm

This comment has been minimized.

Show comment
Hide comment
@agronholm

agronholm Nov 23, 2017

Contributor

Yes, we are using it in our own web app in staging and it's working wonderfully.

Contributor

agronholm commented Nov 23, 2017

Yes, we are using it in our own web app in staging and it's working wonderfully.

@agronholm

This comment has been minimized.

Show comment
Hide comment
@agronholm

agronholm Nov 23, 2017

Contributor

It should also be noted that msgpack5 seems to be actively developed, while msgpack-lite hasn't seen any commits in over a year.

Contributor

agronholm commented Nov 23, 2017

It should also be noted that msgpack5 seems to be actively developed, while msgpack-lite hasn't seen any commits in over a year.

@oberstet

This comment has been minimized.

Show comment
Hide comment
@oberstet

oberstet Nov 23, 2017

Member

I see .. and license is MIT, means also good. ok, cool, thanks! merging.

Member

oberstet commented Nov 23, 2017

I see .. and license is MIT, means also good. ok, cool, thanks! merging.

@oberstet oberstet merged commit e59da86 into crossbario:master Nov 23, 2017

@agronholm

This comment has been minimized.

Show comment
Hide comment
@agronholm

agronholm Nov 23, 2017

Contributor

Thanks!

Contributor

agronholm commented Nov 23, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment