New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed broken msgpack ext type support #331

Merged
merged 1 commit into from Nov 23, 2017

Conversation

Projects
None yet
2 participants
@agronholm
Contributor

agronholm commented Nov 23, 2017

This feature violated WAMP's design goals. Use of ext types should be restricted to scenarios where payload transparency is used. But more importantly, the code was broken by the move to msgpack5.

Removed broken msgpack ext type support
This feature violated WAMP's design goals. Use of ext types should be
restricted to scenarios where payload transparency is used. But more
importantly, the code was broken by the move to msgpack5.

@oberstet oberstet merged commit 8106d2c into crossbario:master Nov 23, 2017

@oberstet

This comment has been minimized.

Show comment
Hide comment
@oberstet

oberstet Nov 23, 2017

Member

agreed!

Member

oberstet commented Nov 23, 2017

agreed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment