Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WAMP over Process Pipes: breaking Twisted v21.2.0 interface change #1470

Closed
oberstet opened this issue Mar 2, 2021 · 2 comments
Closed

WAMP over Process Pipes: breaking Twisted v21.2.0 interface change #1470

oberstet opened this issue Mar 2, 2021 · 2 comments
Labels
bug PRIO HIGH Twisted

Comments

@oberstet
Copy link
Contributor

oberstet commented Mar 2, 2021 •
edited
Loading

The breaking interface change in Twisted relates to Autobahn support for WAMP over pipes to spawned child processes:

  • with Twisted v20.3.0 calling twisted.internet.protocol.ProcessProtocol.getPeer raises an AttributeError
  • with Twisted v21.2.0 calling the same method raises an NotImplementedError
@oberstet
Copy link
Contributor Author

oberstet commented Mar 2, 2021 •
edited
Loading

fixed via #1469 - this works with both Twisted v20.3.0 and v21.2.0

for explanation: crossbario/crossbar#1864 (comment)

@oberstet oberstet closed this as completed Mar 2, 2021
@oberstet oberstet mentioned this issue Mar 2, 2021
Closed
@oberstet
Copy link
Contributor Author

oberstet commented Mar 3, 2021

for the record, the change in twisted is indeed covered by twisted project policy .. see https://twistedmatrix.com/pipermail/twisted-python/2021-March/065507.html and ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug PRIO HIGH Twisted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oberstet