Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseException does not have a .message attribute on Python 3, so connections are never lost when using Twisted #479

Closed
hawkowl opened this issue Sep 5, 2015 · 0 comments
Closed

BaseException does not have a .message attribute on Python 3, so connections are never lost when using Twisted #479

hawkowl opened this issue Sep 5, 2015 · 0 comments
Labels
bug Python 3 Twisted

Comments

@hawkowl
Copy link
Contributor

hawkowl commented Sep 5, 2015

In a log message (https://github.com/tavendo/AutobahnPython/blob/a6b1c46b69bb5b76c81fef980daa2a277a69d2cf/autobahn/twisted/websocket.py#L108), we try and log an exception's .message. This fails, because .message was deprecated in Python 2.6 (http://stackoverflow.com/questions/1272138/baseexception-message-deprecated-in-python-2-6) and removed in Python 3. This code should use .args[0] instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Python 3 Twisted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hawkowl