Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More error handling #358

Closed
wants to merge 5 commits into from
Closed

Conversation

@meejah
Copy link
Member

@meejah meejah commented Mar 12, 2015

This includes unit-tests and fixes for:

  • consistently handle async returns from onLeave etc methods
  • usable, consistent errback API between asyncio/Twisted
  • test-coverage for user-code raising errors
  • test-coverage for exceptions from invoked methods
  • on_progress used consistently everywhere
  • test-coverage for happy-path + exceptions in on_progress handlers
meejah added 5 commits Mar 12, 2015
(At least for pypy2 + twisted)
This includes unit-tests and fixes for:

 - handle async returns from onLeave etc methods
 - usable, consistent errback API between asyncio/Twisted
 - test-coverage for user-code raising errors
 - test-coverage for exceptions from invoked methods
 - on_progress used consistently everywhere
except:
typ, exc, tb = sys.exc_info()
if errback:
errback(typ, exc, tb)
Copy link
Member

@oberstet oberstet Mar 13, 2015

as said, I won't merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants