New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in websocket/protocol.py (s/taxio/txaio) #381

Merged
merged 1 commit into from Apr 15, 2015

Conversation

Projects
None yet
3 participants
@cfillion
Contributor

cfillion commented Apr 15, 2015

Most test cases were raising the following exception when running wstest -m fuzzingclient since 7c5c882:

An exception was raised from application code while processing a reactor selectable
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/twisted/python/log.py", line 88, in callWithLogger
    return callWithContext({"system": lp}, func, *args, **kw)
  File "/usr/local/lib/python2.7/site-packages/twisted/python/log.py", line 73, in callWithContext
    return context.call({ILogContext: newCtx}, func, *args, **kw)
  File "/usr/local/lib/python2.7/site-packages/twisted/python/context.py", line 118, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/usr/local/lib/python2.7/site-packages/twisted/python/context.py", line 81, in callWithContext
    return func(*args,**kw)
--- <exception caught here> ---
  File "/usr/local/lib/python2.7/site-packages/twisted/internet/kqreactor.py", line 277, in _doWriteOrRead
    why = selectable.doRead()
  File "/usr/local/lib/python2.7/site-packages/twisted/internet/tcp.py", line 209, in doRead
    return self._dataReceived(data)
  File "/usr/local/lib/python2.7/site-packages/twisted/internet/tcp.py", line 215, in _dataReceived
    rval = self.protocol.dataReceived(data)
  File "/usr/local/lib/python2.7/site-packages/autobahn/twisted/websocket.py", line 101, in dataReceived
    self._dataReceived(data)
  File "/usr/local/lib/python2.7/site-packages/autobahn/websocket/protocol.py", line 1299, in _dataReceived
    self.consumeData()
  File "/usr/local/lib/python2.7/site-packages/autobahn/websocket/protocol.py", line 1314, in consumeData
    while self.processData() and self.state != WebSocketProtocol.STATE_CLOSED:
  File "/usr/local/lib/python2.7/site-packages/autobahn/websocket/protocol.py", line 1466, in processData
    return self.processDataHybi()
  File "/usr/local/lib/python2.7/site-packages/autobahn/websocket/protocol.py", line 1777, in processDataHybi
    fr = self.onFrameEnd()
  File "/usr/local/lib/python2.7/site-packages/autobahn/websocket/protocol.py", line 1875, in onFrameEnd
    self.processControlFrame()
  File "/usr/local/lib/python2.7/site-packages/autobahn/websocket/protocol.py", line 1931, in processControlFrame
    if self.onCloseFrame(code, reasonRaw):
  File "/usr/local/lib/python2.7/site-packages/autobahn/websocket/protocol.py", line 842, in onCloseFrame
    call = taxio.call_later(
exceptions.NameError: global name 'taxio' is not defined
fix a typo in websocket/protocol.py (s/taxio/txaio)
Most test cases were raising the following exception when running `wstest -m fuzzingclient`:

```
An exception was raised from application code while processing a reactor selectable
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/twisted/python/log.py", line 88, in callWithLogger
    return callWithContext({"system": lp}, func, *args, **kw)
  File "/usr/local/lib/python2.7/site-packages/twisted/python/log.py", line 73, in callWithContext
    return context.call({ILogContext: newCtx}, func, *args, **kw)
  File "/usr/local/lib/python2.7/site-packages/twisted/python/context.py", line 118, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/usr/local/lib/python2.7/site-packages/twisted/python/context.py", line 81, in callWithContext
    return func(*args,**kw)
--- <exception caught here> ---
  File "/usr/local/lib/python2.7/site-packages/twisted/internet/kqreactor.py", line 277, in _doWriteOrRead
    why = selectable.doRead()
  File "/usr/local/lib/python2.7/site-packages/twisted/internet/tcp.py", line 209, in doRead
    return self._dataReceived(data)
  File "/usr/local/lib/python2.7/site-packages/twisted/internet/tcp.py", line 215, in _dataReceived
    rval = self.protocol.dataReceived(data)
  File "/usr/local/lib/python2.7/site-packages/autobahn/twisted/websocket.py", line 101, in dataReceived
    self._dataReceived(data)
  File "/usr/local/lib/python2.7/site-packages/autobahn/websocket/protocol.py", line 1299, in _dataReceived
    self.consumeData()
  File "/usr/local/lib/python2.7/site-packages/autobahn/websocket/protocol.py", line 1314, in consumeData
    while self.processData() and self.state != WebSocketProtocol.STATE_CLOSED:
  File "/usr/local/lib/python2.7/site-packages/autobahn/websocket/protocol.py", line 1466, in processData
    return self.processDataHybi()
  File "/usr/local/lib/python2.7/site-packages/autobahn/websocket/protocol.py", line 1777, in processDataHybi
    fr = self.onFrameEnd()
  File "/usr/local/lib/python2.7/site-packages/autobahn/websocket/protocol.py", line 1875, in onFrameEnd
    self.processControlFrame()
  File "/usr/local/lib/python2.7/site-packages/autobahn/websocket/protocol.py", line 1931, in processControlFrame
    if self.onCloseFrame(code, reasonRaw):
  File "/usr/local/lib/python2.7/site-packages/autobahn/websocket/protocol.py", line 842, in onCloseFrame
    call = taxio.call_later(
exceptions.NameError: global name 'taxio' is not defined
```

@estan estan referenced this pull request Apr 15, 2015

Closed

Fix typo (taxio -> txaio). #382

oberstet added a commit that referenced this pull request Apr 15, 2015

Merge pull request #381 from cfillion/master
Fix a typo in websocket/protocol.py (s/taxio/txaio)

@oberstet oberstet merged commit 552986a into crossbario:master Apr 15, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@meejah meejah referenced this pull request May 7, 2015

Closed

NameError in protocol.py #391

@joakime

This comment has been minimized.

joakime commented May 8, 2015

Can we see a release that works with pip install for this please?

@oberstet

This comment has been minimized.

Member

oberstet commented May 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment