Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper twisted extras requirements #1559

Closed
oberstet opened this issue Apr 13, 2019 · 1 comment
Closed

Add proper twisted extras requirements #1559

oberstet opened this issue Apr 13, 2019 · 1 comment

Comments

@oberstet
Copy link
Contributor

Currently, we have a dependency on plain twisted[], while we in fact use stuff from Twisted which is in extras - and that only worked by accident because we have other explicit or indirect requirements that happen to be the same as Twisted extras.

We should fix that properly, eg this one #1555 actually is a consequence of our incorrect dependencies.

The Twisted extras we do want are:

  • all platforms: twisted[tls,conch,http2]
  • additionally on osx: twisted[osx_platform]
  • additionally on windows: twisted[windows_platform]

ref: https://github.com/twisted/twisted/blob/c25dcb9d4a2388710c7b2e4a2bd7242ec6747b50/src/twisted/python/_setup.py#L90

@oberstet
Copy link
Contributor Author

fixed via #1570

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant