New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another incorrect atomic orderings in MS Queue? #100

Closed
jeehoonkang opened this Issue Dec 30, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@jeehoonkang
Contributor

jeehoonkang commented Dec 30, 2016

I think a Relaxed load from self.tail into tail in ms_queue.rs should be Acquire: https://github.com/aturon/crossbeam/blob/master/src/sync/ms_queue.rs#L280

Because later the loaded value (effectively tail.next) is used as a pointer (https://github.com/aturon/crossbeam/blob/master/src/sync/ms_queue.rs#L296 https://github.com/aturon/crossbeam/blob/master/src/sync/ms_queue.rs#L87), and with only the Relaxed ordering, it is not guaranteed that a load from tail.next sees an initialized value.

jeehoonkang added a commit to jeehoonkang/crossbeam that referenced this issue Apr 7, 2017

@stjepang stjepang closed this in #132 May 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment