Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide loom from dependency graph #665

Closed
djc opened this issue Feb 23, 2021 · 3 comments · Fixed by #666
Closed

Hide loom from dependency graph #665

djc opened this issue Feb 23, 2021 · 3 comments · Fixed by #666
Labels
crossbeam-epoch crossbeam-utils

Comments

@djc
Copy link

djc commented Feb 23, 2021

The way loom is set up now, loom and its dependencies show up in my dep graph as soon as I depend on crossbeam-utils or crossbeam-epoch. It would be nice to avoid this, for example as done in https://github.com/hawkw/sharded-slab/pull/52/files. (I can do the legwork on this if you like.)
@taiki-e
Copy link
Member

taiki-e commented Feb 23, 2021

yeah, we plan to do that #487 (comment)

@taiki-e taiki-e changed the title Make loom dependencies off by default Hide loom from dependencies graph Feb 23, 2021
@taiki-e taiki-e changed the title Hide loom from dependencies graph Hide loom from dependency graph Feb 23, 2021
@taiki-e
Copy link
Member

taiki-e commented Feb 23, 2021

(also, it will be downloaded but not actually compiled.)

@taiki-e taiki-e mentioned this issue Feb 23, 2021
Merged
@taiki-e
Copy link
Member

taiki-e commented Feb 23, 2021

will be fixed by #666

@bors bors bot closed this as completed in f8c9922 Feb 23, 2021
@taiki-e taiki-e mentioned this issue Sep 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crossbeam-epoch crossbeam-utils
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make loom dependency optional crossbeam-rs/crossbeam
2 participants
@djc @taiki-e