From 8aa68a25584caccab606849a1a1135cde9663579 Mon Sep 17 00:00:00 2001 From: Muvaffak Onus Date: Thu, 4 Mar 2021 21:05:21 +0300 Subject: [PATCH] database.rdsinstance: add missing dbparametergroupname to late init function so that isUpToDate works properly. Signed-off-by: Muvaffak Onus --- examples/database/rdsinstance.yaml | 3 +-- pkg/clients/rds/rds.go | 8 ++++++++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/examples/database/rdsinstance.yaml b/examples/database/rdsinstance.yaml index e9e7e94678..3c5d1dd03a 100644 --- a/examples/database/rdsinstance.yaml +++ b/examples/database/rdsinstance.yaml @@ -4,6 +4,7 @@ metadata: name: example-rds spec: forProvider: + region: us-east-1 allocatedStorage: 20 autoMinorVersionUpgrade: true backupRetentionPeriod: 0 @@ -20,8 +21,6 @@ spec: masterUsername: admin multiAZ: true port: 3306 - preferredBackupWindow: 06:15-06:45 - preferredMaintenanceWindow: sat:09:21-sat:09:51 publiclyAccessible: false storageEncrypted: false storageType: gp2 diff --git a/pkg/clients/rds/rds.go b/pkg/clients/rds/rds.go index bc9cce2d02..733363bd34 100644 --- a/pkg/clients/rds/rds.go +++ b/pkg/clients/rds/rds.go @@ -442,6 +442,14 @@ func LateInitialize(in *v1beta1.RDSInstanceParameters, db *rds.DBInstance) { // if strings.HasPrefix(aws.StringValue(db.EngineVersion), aws.StringValue(in.EngineVersion)) { in.EngineVersion = db.EngineVersion } + if in.DBParameterGroupName == nil { + for i := range db.DBParameterGroups { + if db.DBParameterGroups[i].DBParameterGroupName != nil { + in.DBParameterGroupName = db.DBParameterGroups[i].DBParameterGroupName + break + } + } + } } // IsUpToDate checks whether there is a change in any of the modifiable fields.