fix(acm): correct description for dvo #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rushrs
changed the title
rushrs
force-pushed
the
patch-1
branch
2 times, most recently
from
f6185ae
to
158ec93
Compare
|
Thanks for the fixes, @rushrs. Could you please squash your changes into a single commit and append |
will do that now |
|
just updated it @MisterMX |
Signed-off-by: rushrs <17338080+rushrs@users.noreply.github.com> update description for dvo Signed-off-by: rushrs <17338080+rushrs@users.noreply.github.com> update description for dvo Signed-off-by: rushrs <17338080+rushrs@users.noreply.github.com> update description for dvo api Signed-off-by: rushrs <17338080+rushrs@users.noreply.github.com> Update certificate_types.go Signed-off-by: rushrs <17338080+rushrs@users.noreply.github.com> another small formatting fix Signed-off-by: rushrs <17338080+rushrs@users.noreply.github.com> another small formatting fix Signed-off-by: rushrs <17338080+rushrs@users.noreply.github.com> add modified file Signed-off-by: rushrs <17338080+rushrs@users.noreply.github.com>
|
Hi @MisterMX, I didn't realise this wasn't successful. i've made the changes to fix the error shown in CI now. |
MisterMX
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Just fixing a spelling mistake that was bothering me whilst I was looking through the provider docs.
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested