feat(firehose): Add DevileryStream controller #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilde
changed the title
nilde
force-pushed
the
firehose
branch
3 times, most recently
from
7f71f32
to
c76bc0d
Compare
|
For the record: This actually contains the implementation for Firehose that was supposed to bemerged with #1885 but for due to some mistake was not merged (only minor refactorings got merged appearently). @nilde could you squash all changes into a single commit and sign them? Please also make sure that the commit message follows the conventional commits standard. Since you are actually adding a feature here it might make sense to change it into something like |
nilde
force-pushed
the
firehose
branch
2 times, most recently
from
0545e8f
to
08c129a
Compare
MisterMX
changed the title
MisterMX
requested changes
Oct 20, 2023
nilde
force-pushed
the
firehose
branch
2 times, most recently
from
4e96d6c
to
8bf92cc
Compare
Signed-off-by: Domene Esteban, Nil {DISB~SANT CUGAT DIA} <Nil.Domene@e-campus.uab.cat>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #1890 but for firehose.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested locally