refactor(pointer): Use generic pointer functions #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlunde
reviewed
Oct 24, 2023
chlunde
approved these changes
Oct 24, 2023
* Add generic functions for late initialize and pointer refs and derefs. * Replace calls that are using the `pointer.FieldRequired` option with ptr.To which as the same effect but is much simpler. * Remove pointer functions that are not used anymore. * Change pointer functions so they don't depend on the AWS sdk anymore but only `k8s.io/utils/ptr`. Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <maximilian.blatt-extern@deutschebahn.com>
MisterMX
force-pushed
the
refactor/pointer-simplify
branch
from
3a9f4ed
to
6f0657a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Some more refactoring for pointer functions:
pointer.FieldRequiredoption with ptr.To which as the same effect but is much simpler.k8s.io/utils/ptr.No behavioral changes to the code have been made.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
n.a.