Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement integration testing across Crossplane ecosystem #1033

Closed
3 of 6 tasks
hasheddan opened this issue Nov 6, 2019 · 4 comments
Closed
3 of 6 tasks

Implement integration testing across Crossplane ecosystem #1033

hasheddan opened this issue Nov 6, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@hasheddan
Copy link
Member

hasheddan commented Nov 6, 2019

What problem are you facing?

Currently, all integration testing across the Crossplane ecosystem is performed in a manual ad-hoc manner that results in a significant amount of inefficient effort and uncaught errors leading up to new releases. It is desirable to run automated integration tests on a more frequent basis such that errors are caught faster and releases are delivered more smoothly.

How could Crossplane help solve your problem?

Developing a framework that can be used across Crossplane projects would standardize the implementation and execution of integration tests. The initial implementation should be broad and flexible, deferring much of the logic to the written tests. Over time, commonly used tests and functionality can be incorporated into the framework itself.

Steps

@hasheddan hasheddan added the enhancement New feature or request label Nov 6, 2019
@hasheddan hasheddan added this to the v0.5 milestone Nov 6, 2019
@hasheddan hasheddan self-assigned this Nov 6, 2019
@jbw976 jbw976 added the epic label Nov 6, 2019
@jbw976 jbw976 modified the milestones: v0.5, v0.6 Nov 15, 2019
@jbw976 jbw976 modified the milestones: v0.6, v0.7 Dec 21, 2019
@jbw976 jbw976 modified the milestones: v0.7, v0.8 Jan 22, 2020
@suskin
Copy link
Member

suskin commented Jan 30, 2020

Summarizing some discussion on this from Slack with @hasheddan:

As a developer, I'd like to run fast, narrowly scoped "integration" tests which test my controller logic (for example). I'd like to be able to run them as part of my PR test suite, for ones which are fast enough and which don't use external resources or infrastructure.

This would likely be accomplished by allowing us to easily use the local mode of the envtest library, which depends on local apiserver binaries being available. Solving it in this way would mean updating the build images to include those binaries.

This came up in the context of a test in #1214

suskin added a commit to suskin/crossplane that referenced this issue Jan 30, 2020
Our CI environment doesn't quite support envtest-based integration tests
which use a local apiserver, so the test is skipped until we add support
for that. The issue tracking this is crossplane#1033

Signed-off-by: suskin <813571+suskin@users.noreply.github.com>
@jbw976 jbw976 modified the milestones: v0.8, v0.9 Feb 21, 2020
@jbw976 jbw976 removed this from the v0.9 milestone Mar 25, 2020
@negz
Copy link
Member

negz commented Aug 17, 2021

@hasheddan, @rahulgrover99 do you know if this issue should still be "In Progress" in the v1.4 timeframe? Is it being actively worked on?

@hasheddan
Copy link
Member Author

@negz is it not to my knowledge. I feel like it would it make sense to close this one out as much of the context is stale, and more specific issues related to this effort would serve as better items for folks to work on.

@stale
Copy link

stale bot commented Aug 14, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants