New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mvc 5-3 project and test. #23

Open
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
@Eonasdan

Updated nuget packges, fixed some spelling, used c# 6 where available, general code clean up and most importantly removed unnecessary decencies.

Added mvc 5-3 project and test. Updated nuget packges, fixed some spe…
…lling, used c# 6 where available, general code clean up and most importantly removed unnecessary decencies.
@Eonasdan

This comment has been minimized.

Show comment
Hide comment
@Eonasdan

Eonasdan Feb 17, 2016

I have some powershell scripts that can automatically create nuget packages in case you're interested

I have some powershell scripts that can automatically create nuget packages in case you're interested

@Eonasdan

This comment has been minimized.

Show comment
Hide comment
@Eonasdan

Eonasdan Feb 29, 2016

went ahead and published my own nuget package https://www.nuget.org/packages/ActionMailerNext.Mvc5-3/

went ahead and published my own nuget package https://www.nuget.org/packages/ActionMailerNext.Mvc5-3/

CheCoxshall and others added some commits Mar 15, 2016

MailAttributes.From property may be null
As From is optional, allowed the 'From' property to be null. Otherwise,
a NullReferenceException occurs when attempting to access
'mail.From.Address'
Merge pull request #1 from CheCoxshall/master
MailAttributes.From property may be null
@Eonasdan

This comment has been minimized.

Show comment
Hide comment
@Eonasdan

Eonasdan Mar 15, 2016

unfortunately, the fix to the From address added to my branch from @CheCoxshall is part of the core project which means I can't simply publish my nuget package to fix it. We'll have to wait for someone on the team to merge and update it (like maybe @stukalin ?).

unfortunately, the fix to the From address added to my branch from @CheCoxshall is part of the core project which means I can't simply publish my nuget package to fix it. We'll have to wait for someone on the team to merge and update it (like maybe @stukalin ?).

@CheCoxshall

This comment has been minimized.

Show comment
Hide comment
@CheCoxshall

CheCoxshall Mar 15, 2016

Ah - may be an issue there as it's using the c# 6.0 safe navigation operator!

Ah - may be an issue there as it's using the c# 6.0 safe navigation operator!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment