Adding morphology indexing - JS-226#10
Closed
chrisburrell wants to merge 24 commits into
Closed
Conversation
…nges in anything that extends Book?
… return the correct URI
…ather than re-open every time
…eporting errors for short book names
…o provide mechanism for releasing resources
Contributor
|
closing this, changes are better addressed via a branch on the pull request #11 |
Contributor
|
well, looks like the morphology indexing is good on the other branch, but at the same time @dmsmith did a through review on tyndale/master and it looks like there good changes there @chrisburrell could you review @dmsmith comments and try to formulate those changes into more pull-requests? |
dmsmith
pushed a commit
that referenced
this pull request
Jan 23, 2025
…blication Bugfix #1815/declare maven publication
dmsmith
pushed a commit
that referenced
this pull request
Feb 26, 2025
add definition of variant tag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forget this one - i meant to push through a branch - I don't seem to be able to cancel this.