Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
new crowbar_batch script #1147
(see #1152 for backport to
will automatically create (if necessary), edit, and apply all proposals described within
added a commit
this pull request
Oct 23, 2014
@aspiers I just looked at the code briefly, but in general:
Maybe that more stuff (e.g. consistent response handling, common code for API consumption, logging) will arise if the above is accomplished.
I know this is just 'another script' in the suite (which already is a mess), but from what you say, there are plans to extend it, so this will be read/modified many times and the time investment will pay off, IMHO.
Not sure I follow - the only 1.8.7 workaround I know of isn't in
Depends on what you mean by "the above". Classes would definitely help, for sure. But this is a major
I don't have plans to extend it. How did I mistakenly give you that idea?
Actually I view this particular script as more or less "done" already. It does two simple things pretty
Yeah, sorry, this was a bad example. The problem I was trying to point out was, that the workaround-methods are mixed with the other ones (functionality vs. low level noise), not that they call / contain each other.
This can be done just for this script. From that, it'll be more clear what is required for the other scripts and the lib. Also, it'd be a good example how adding just some encapsulation / logical grouping can make the other scripts so much better. Process-wise, the bigger refactoring can be handled however you see fit and can be done by someone else.
Initially, I assumed that 'and eventually maybe even partially mimicking customer environments.' would mean this would need to be extended or modified somehow. And your commit 779e326 seems to suggests that as well - or do I get that wrong?
Yes, this is functionality wise. But in order to review it, and make sense of it just by looking at the code, you have to parse 500 lines of unstructured stuff - basically just a long list of functions that do 'something'. Adding some structure, however crude, will help a lot, imho.
Balazs Kutil email@example.com wrote:
I don't see how else to do it without also doing a major refactoring of
How? I really don't think it can, because the API calls are inextricably interwined with
It's already fairly clear to me, I just don't have time to do it yet.
Happy to if it's quick and simple - concrete suggestions welcome.
It can already do that. Just
Now you're cheating because I added that TODO list after you guessed there were plans to extend it ;-) But really they are just three minor tweaks rather than major extensions.
Like I said, I'm not really sure what you mean but I'm happy to do quick and simple small changes if you can suggest them. But I'm already flat out preparing for Paris and SUSEcon, so bigger changes will have to wait.