Skip to content
This repository has been archived by the owner. It is now read-only.

Add support for docker #440

Merged
merged 2 commits into from Apr 10, 2015
Merged

Add support for docker #440

merged 2 commits into from Apr 10, 2015

Conversation

@vuntz
Copy link
Member

vuntz commented Mar 12, 2015

No description provided.

@@ -2457,6 +2459,11 @@ api_insecure=<%= @cinder_insecure ? 'True' : 'False' %>
workers=<%= [node["cpu"]["total"], 2, 4].sort[1] %>


[docker]
# vif_driver=novadocker.virt.docker.vifs.DockerGenericVIFDriver

This comment has been minimized.

@tboerger

tboerger Mar 16, 2015 Contributor

Does it make sense to make it configurable?

@tboerger
Copy link
Contributor

tboerger commented Mar 16, 2015

👍

@rsalevsky
Copy link
Member

rsalevsky commented Mar 25, 2015

works good +1

@mjura
Copy link
Contributor

mjura commented Mar 26, 2015

👍

1 similar comment
@rossella
Copy link
Contributor

rossella commented Apr 1, 2015

+1

@jsuchome
Copy link
Contributor

jsuchome commented Apr 3, 2015

+1 tested, and this part of docker support works well

vuntz added 2 commits Mar 11, 2015
We do not need to install libvirt and do libvirt-related actions on
vmware or docker compute nodes.
@vuntz vuntz force-pushed the vuntz:docker branch from c7cc94c to fa5a53d Apr 3, 2015
@vuntz
Copy link
Member Author

vuntz commented Apr 3, 2015

Rebased and added some new cleanup so that we don't install libvirt on a docker node.

@jsuchome
Copy link
Contributor

jsuchome commented Apr 9, 2015

Tested with rebased PR, still works :-)

vuntz added a commit that referenced this pull request Apr 10, 2015
Add support for docker
@vuntz vuntz merged commit c6fa8c6 into crowbar:master Apr 10, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.