New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for docker #440

Merged
merged 2 commits into from Apr 10, 2015

Conversation

6 participants
@vuntz
Member

vuntz commented Mar 12, 2015

No description provided.

@@ -2457,6 +2459,11 @@ api_insecure=<%= @cinder_insecure ? 'True' : 'False' %>
workers=<%= [node["cpu"]["total"], 2, 4].sort[1] %>
[docker]
# vif_driver=novadocker.virt.docker.vifs.DockerGenericVIFDriver

This comment has been minimized.

@tboerger

tboerger Mar 16, 2015

Contributor

Does it make sense to make it configurable?

@tboerger

tboerger Mar 16, 2015

Contributor

Does it make sense to make it configurable?

@tboerger

This comment has been minimized.

Show comment
Hide comment
@tboerger

tboerger Mar 16, 2015

Contributor

👍

Contributor

tboerger commented Mar 16, 2015

👍

@rsalevsky

This comment has been minimized.

Show comment
Hide comment
@rsalevsky

rsalevsky Mar 25, 2015

Member

works good +1

Member

rsalevsky commented Mar 25, 2015

works good +1

@mjura

This comment has been minimized.

Show comment
Hide comment
@mjura

mjura Mar 26, 2015

Contributor

👍

Contributor

mjura commented Mar 26, 2015

👍

@rossella

This comment has been minimized.

Show comment
Hide comment
@rossella

rossella Apr 1, 2015

Contributor

+1

Contributor

rossella commented Apr 1, 2015

+1

@jsuchome

This comment has been minimized.

Show comment
Hide comment
@jsuchome

jsuchome Apr 3, 2015

Contributor

+1 tested, and this part of docker support works well

Contributor

jsuchome commented Apr 3, 2015

+1 tested, and this part of docker support works well

vuntz added some commits Mar 11, 2015

Reorganize compute recipe code
We do not need to install libvirt and do libvirt-related actions on
vmware or docker compute nodes.
@vuntz

This comment has been minimized.

Show comment
Hide comment
@vuntz

vuntz Apr 3, 2015

Member

Rebased and added some new cleanup so that we don't install libvirt on a docker node.

Member

vuntz commented Apr 3, 2015

Rebased and added some new cleanup so that we don't install libvirt on a docker node.

@jsuchome

This comment has been minimized.

Show comment
Hide comment
@jsuchome

jsuchome Apr 9, 2015

Contributor

Tested with rebased PR, still works :-)

Contributor

jsuchome commented Apr 9, 2015

Tested with rebased PR, still works :-)

vuntz added a commit that referenced this pull request Apr 10, 2015

@vuntz vuntz merged commit c6fa8c6 into crowbar:master Apr 10, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment