This repository was archived by the owner on Dec 4, 2018. It is now read-only.
Merged
Conversation
Contributor
There was a problem hiding this comment.
Does it make sense to make it configurable?
Contributor
|
👍 |
Member
|
works good +1 |
Contributor
|
👍 |
1 similar comment
Contributor
|
+1 |
Member
|
+1 tested, and this part of docker support works well |
We do not need to install libvirt and do libvirt-related actions on vmware or docker compute nodes.
Member
Author
|
Rebased and added some new cleanup so that we don't install libvirt on a docker node. |
Member
|
Tested with rebased PR, still works :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.