Skip to content
This repository has been archived by the owner on Dec 4, 2018. It is now read-only.

Use docker image when compute nodes are using docker #140

Merged
merged 6 commits into from
May 12, 2015

Conversation

vuntz
Copy link
Member

@vuntz vuntz commented Apr 27, 2015

No description provided.

--is-public True
--page-size 1
2> /dev/null | tail -n 2 | head -n 1 | awk '{ print $2 }')
[ -n "$DOCKER_IMAGE_ID" ] && echo $"$DOCKER_IMAGE_ID" > #{docker_image_id_file}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why $"$DOCKER_IMAGE_ID"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a bug :-)

@vuntz vuntz force-pushed the docker branch 3 times, most recently from cb785c1 to 0f12493 Compare April 27, 2015 12:35
vuntz added 3 commits April 27, 2015 14:35
Rescue doesn't make sense for docker and won't be implemented, see
http://blog-calfonso.rhcloud.com/?p=84
This is not implemented in the docker driver, so can't work.
@vuntz
Copy link
Member Author

vuntz commented Apr 27, 2015

Smoketests are passing with this.

@vuntz
Copy link
Member Author

vuntz commented Apr 28, 2015

For the record, we're down to:

Ran 1524 tests in 5523.572s

FAILED (failures=11)

@vuntz vuntz added this to the sprint 19 milestone Apr 28, 2015
@jsuchome
Copy link
Member

+1 I think current results are quite good

@ovisan
Copy link

ovisan commented May 12, 2015

👍 cool

vuntz added a commit that referenced this pull request May 12, 2015
Use docker image when compute nodes are using docker
@vuntz vuntz merged commit 4c3c6b0 into crowbar:master May 12, 2015
This was referenced Jul 31, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants