This repository has been archived by the owner on Dec 4, 2018. It is now read-only.
forked from MirantisDellCrowbar/barclamp-tempest
-
Notifications
You must be signed in to change notification settings - Fork 114
Use docker image when compute nodes are using docker #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--is-public True | ||
--page-size 1 | ||
2> /dev/null | tail -n 2 | head -n 1 | awk '{ print $2 }') | ||
[ -n "$DOCKER_IMAGE_ID" ] && echo $"$DOCKER_IMAGE_ID" > #{docker_image_id_file} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why $"$DOCKER_IMAGE_ID"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was a bug :-)
cb785c1
to
0f12493
Compare
Rescue doesn't make sense for docker and won't be implemented, see http://blog-calfonso.rhcloud.com/?p=84
This is not implemented in the docker driver, so can't work.
Smoketests are passing with this. |
This is not supported yet, see https://bugs.launchpad.net/nova-docker/+bug/1321818
There's no suspend/resume support in docker.
For the record, we're down to: Ran 1524 tests in 5523.572s FAILED (failures=11) |
+1 I think current results are quite good |
👍 cool |
vuntz
added a commit
that referenced
this pull request
May 12, 2015
Use docker image when compute nodes are using docker
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.