Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monasca: Add openvswitch plugin (SCRD-7571) #2081

Merged
merged 3 commits into from May 14, 2019

Conversation

witekest
Copy link
Contributor

@witekest witekest commented Apr 2, 2019

Add Monasca OVS plugin configuration on all neutron-network nodes.
Plugin configuration is automatically enabled and can be disabled in
Crowbar UI.

Monasca OVS plugin autodetection is disabled on Monasca server node.

Add monasca-agent role to delegate_authorized_roles to enable
collecting tenant metrics.

@witekest witekest requested a review from jgrassler as a code owner April 2, 2019 13:39
@witekest witekest requested review from toabctl and vuntz April 2, 2019 13:39
attrs["agent"].key?("monitor_ovs")

attrs["agent"]["plugins"] = template_attrs["agent"]["plugins"] unless
attrs["agent"].key?("plugins")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could be wrong but I don't think this will do what you want, the template already has a pre-existing "plugins" dictionary, so either this will not add in the new "ovs" key or it will overwrite the old version with the defaults in the template instead of the user-set values. I think this should be attrs["agent"]["plugins"]["ovs"] = template_attrs... etc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thank you.

Add `monasca-agent` role to `delegate_authorized_roles` to enable
collecting tenant metrics. It will allow creating dashboards and alarm
definitions for users in projects different then `monasca`.
jgrassler
jgrassler previously approved these changes Apr 25, 2019
Copy link
Contributor

@jgrassler jgrassler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine (OpenVSwitch metrics rolling in now). Thanks!

Add Monasca OVS plugin configuration on all neutron-network nodes.
Plugin configuration is automatically enabled and can be disabled in
Crowbar UI.

Monasca OVS plugin autodetection is disabled on Monasca server node.
Monasca notification engine requires initialized DB schema to update the
list of enabled notification plugins on service start. This change moves
`monasca-notification` recipe after `monasca-api` recipe where DB schema
initialisation is executed.
Copy link
Contributor

@cmurphy cmurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern was addressed

@toabctl toabctl merged commit 6263ddf into crowbar:master May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants