use heredocs #2197
Open
use heredocs #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heredocs makes it a bit nicer to read and write inline text.
| puts " cd \"#{target}\"; find -type f -not -name sha1sums -print0 | \\" | ||
| puts" xargs -0 sha1sum -b >sha1sums" | ||
| puts "(or use the --force switch)" | ||
| print <<-EOF.gsub(/^ *\| /, '') |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. (https://github.com/bbatsov/ruby-style-guide#consistent-string-literals)
|
Codeclimate works, but your changes are getting removed anyway within #2195, so closing this issue. |
|
@tboerger but now Jenna can't see that it worked ... |
|
Reopened just to show the Codeclimate support that it works without a fork. |
|
@aspiers can this be closed now? |
|
@aspiers Is this still an issue you want to keep open? |
|
@nicolasbock Sure why not - all those |
rsalevsky
approved these changes
Jan 18, 2017
|
@aspiers needs rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heredocs makes it a bit nicer to read and write inline text.
This is a half-serious untested pull-request submitted mainly to test whether CodeClimate works on PRs within a single repo (in contrast we know for sure that there are existing issues with cross-fork PRs, but CodeClimate said they should have these fixed very soon).