This repository was archived by the owner on Oct 10, 2025. It is now read-only.
PLAT-14359 #70
Merged
PLAT-14359 #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylor-cb
reviewed
Apr 4, 2024
scripts/setModuleDetails.js
Outdated
| ) => { | ||
| const patchBody = {}; | ||
|
|
||
| section("To ensure the entire string is saved, please use double quotes around the string value."); |
Contributor
There was a problem hiding this comment.
I think we could use some validation here to ensure that at least one value is being set. Like
if(Object.keys(patchBody).length === 0)
Then we can print this warning inside there if they didnt provide any values to set.
taylor-cb
reviewed
Apr 4, 2024
scripts/setModuleDetails.js
Outdated
| valid(`Module details updated for ${id}.`); | ||
| } else { | ||
| patchSpinner.stop(); | ||
| invalid(`Unable to update module details for ${id}. Please try again.`); |
Contributor
There was a problem hiding this comment.
Suggest checking for status === 404 and printing a nicer message.
taylor-cb
approved these changes
Apr 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
PLAT-14359
Related tickets:
Related PRs:
Type of PR
Changes introduced
Test and review
Describe how a reviewer should test your PR