New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/apiserver: fix dropped error #700

Merged

buixor merged 2 commits into crowdsecurity:master from alrs:apiserver-err

Apr 7, 2021

Contributor

alrs commented Mar 19, 2021

This fixes a dropped error and prunes an unused context.Context from pkg/apiserver.

Even if the Context was being used, the Go documentation recommends against that. From go doc context:

Do not store Contexts inside a struct type; instead, pass a Context
explicitly to each function that needs it. The Context should be the first
parameter, typically named ctx:

alrs added 2 commits

March 18, 2021 17:36


          pkg/apiserver: fix dropped error

2636d53


          pkg/apiserver: remove unused Context from APIServer{}

3fdec95

buixor approved these changes

View reviewed changes

Contributor

buixor left a comment

lgtm, thanks for your contribution

buixor merged commit d86ba98 into crowdsecurity:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment