Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub Authentication #282
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thank you for the great PR. |
|
Codes are almost okay! |
lib/routes/login.js
Outdated
| delete req.session.socialId; | ||
| delete req.session.socialEmail; | ||
| delete req.session.socialName; | ||
| delete req.session.socialImage; |
This comment has been minimized.
This comment has been minimized.
| var loginSuccess = function(req, res, userData) { | ||
| req.user = req.session.user = userData; | ||
| if (!userData.password) { | ||
| return res.redirect('/me/password'); | ||
| } | ||
|
|
||
| clearGoogleSession(req); | ||
| clearSession(req); |
This comment has been minimized.
This comment has been minimized.
lib/routes/login.js
Outdated
| return res.redirect('/login?register=1'); | ||
| } | ||
| if (githubOrganizations && !User.isGitHubAccountValid(githubOrganizations)) { | ||
| req.flash('registerWarningMessage', 'このアカウントはコネクトできません。'); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@lightnet328 Can you merge current master to resolve conflicts? |
lib/routes/me.js
Outdated
|
|
||
| var userData = req.user; | ||
|
|
||
| var toDisconnect = req.body.disconnectGitHub ? true : false; |
This comment has been minimized.
This comment has been minimized.
|
@lightnet328 I met some errors while QA. |
lib/views/me/index.html
Outdated
|
|
||
| <div class="col-sm-12"> | ||
| <div class="text-center"> | ||
| <input type="submit" name="connectGitHub" class="btn btn-github" value="GitHubコネクト"> |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sotarok
Jun 9, 2018
Member
And, after click this button, I met an error below:
TypeError: Cannot set property 'callbackAction' of undefined
at actions.authGitHub (/Users/sotarok/working/crowi/crowi/lib/routes/me.js:291:41)
Is this feature (link account after account created) working?
This comment has been minimized.
This comment has been minimized.
lightnet328
Jun 11, 2018
Author
Member
Well, it seems that it was not in a state to work after refactoring...
I fixed and translated it now.
lib/routes/login.js
Outdated
| return loginFailure(req, res); | ||
| } | ||
|
|
||
| const { githubId: user_id } = tokenInfo; |
This comment has been minimized.
This comment has been minimized.
sotarok
Jun 9, 2018
Member
Here met an error:
(node:84115) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): ReferenceError: githubId is not defined
Is const { user_id: githubId } instead?
|
Approved! it worked. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
lightnet328 commentedMar 22, 2018
•
edited
Overview
I implemented a feature to log in to Crowi using GitHub account.
Features
Changed
before: /registerafter: /register/googleScreens