GitHub Authentication #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the great PR. |
sotarok
reviewed
May 31, 2018
lib/routes/login.js
Outdated
| delete req.session.socialId; | ||
| delete req.session.socialEmail; | ||
| delete req.session.socialName; | ||
| delete req.session.socialImage; |
| var loginSuccess = function(req, res, userData) { | ||
| req.user = req.session.user = userData; | ||
| if (!userData.password) { | ||
| return res.redirect('/me/password'); | ||
| } | ||
|
|
||
| clearGoogleSession(req); | ||
| clearSession(req); |
lib/routes/login.js
Outdated
| return res.redirect('/login?register=1'); | ||
| } | ||
| if (githubOrganizations && !User.isGitHubAccountValid(githubOrganizations)) { | ||
| req.flash('registerWarningMessage', 'このアカウントはコネクトできません。'); |
There was a problem hiding this comment.
Can you make above of two messages English?
|
@lightnet328 Can you merge current master to resolve conflicts? |
hiroppy
reviewed
Jun 1, 2018
lib/routes/me.js
Outdated
|
|
||
| var userData = req.user; | ||
|
|
||
| var toDisconnect = req.body.disconnectGitHub ? true : false; |
There was a problem hiding this comment.
const toDisconnect = !!req.body.disconnectGitHub;
sotarok
requested changes
Jun 9, 2018
lib/views/me/index.html
Outdated
|
|
||
| <div class="col-sm-12"> | ||
| <div class="text-center"> | ||
| <input type="submit" name="connectGitHub" class="btn btn-github" value="GitHubコネクト"> |
There was a problem hiding this comment.
I found this button shows Japanese, should be translated.
There was a problem hiding this comment.
And, after click this button, I met an error below:
TypeError: Cannot set property 'callbackAction' of undefined
at actions.authGitHub (/Users/sotarok/working/crowi/crowi/lib/routes/me.js:291:41)
Is this feature (link account after account created) working?
There was a problem hiding this comment.
Well, it seems that it was not in a state to work after refactoring...
I fixed and translated it now.
lib/routes/login.js
Outdated
| return loginFailure(req, res); | ||
| } | ||
|
|
||
| const { githubId: user_id } = tokenInfo; |
There was a problem hiding this comment.
Here met an error:
(node:84115) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): ReferenceError: githubId is not defined
Is const { user_id: githubId } instead?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Overview
I implemented a feature to log in to Crowi using GitHub account.
Features
Changed
before: /registerafter: /register/googleScreens