New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw TypeError when passing booleans to arrow.get #259

Merged
merged 1 commit into from Nov 17, 2016

Conversation

Projects
None yet
2 participants
@EvanHahn
Contributor

EvanHahn commented Aug 20, 2015

Before:

>>> arrow.get(False)
<Arrow [1970-01-01T00:00:00+00:00]>

>>> arrow.get(True)
<Arrow [1970-01-01T00:00:01+00:00]>

After:

>>> arrow.get(False)
TypeError: Can't parse single argument type of '<type 'bool'>'

>>> arrow.get(True)
TypeError: Can't parse single argument type of '<type 'bool'>'

Closes #238.

Throw TypeError when passing booleans to arrow.get
Before:

>>> arrow.get(False)
<Arrow [1970-01-01T00:00:00+00:00]>

>>> arrow.get(True)
<Arrow [1970-01-01T00:00:01+00:00]>

After:

>>> arrow.get(False)
TypeError: Can't parse single argument type of '<type 'bool'>'

>>> arrow.get(True)
TypeError: Can't parse single argument type of '<type 'bool'>'
@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Mar 18, 2016

Contributor

Any updates on this? No problem if not.

Contributor

EvanHahn commented Mar 18, 2016

Any updates on this? No problem if not.

@andrewelkins andrewelkins merged commit 4d31d9a into crsmithdev:master Nov 17, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EvanHahn EvanHahn deleted the EvanHahn:fix-238 branch Nov 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment