Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify how to refer to container for test #76

Merged
merged 3 commits into from Nov 19, 2019

Conversation

sasumasa
Copy link
Contributor

@sasumasa sasumasa commented Nov 7, 2019

As mentioned at #57, It seems that test with Jest fails because of how to refer to container.

I would like to use this library with test. So I've changed codes by following issue above. It's subtle change 馃檪

@sasumasa sasumasa changed the title Modify how to refer to container for test Modify how to refer to container for test[WIP] Nov 7, 2019
@sasumasa
Copy link
Contributor Author

sasumasa commented Nov 7, 2019

I've realized this code does not work... I'll try to fix them

@sasumasa sasumasa changed the title Modify how to refer to container for test[WIP] Modify how to refer to container for test Nov 7, 2019
@sasumasa
Copy link
Contributor Author

sasumasa commented Nov 7, 2019

I fixed bug 馃檹

@crubier
Copy link
Owner

crubier commented Nov 19, 2019

Looks good to me

@crubier crubier merged commit b86b4eb into crubier:master Nov 19, 2019
@sasumasa sasumasa deleted the modify-container-reference branch November 20, 2019 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants