Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments are only block style #78

Closed
woolgathering opened this issue Dec 11, 2016 · 5 comments
Closed

Comments are only block style #78

woolgathering opened this issue Dec 11, 2016 · 5 comments

Comments

@woolgathering
Copy link
Contributor

woolgathering commented Dec 11, 2016

Cmd-/ only uses the block comment style, even on single lines. This only occurs when using the Supercollider syntax and not other syntaxes. I've tried editing grammars/supercollider.cson for a fix but I'm really just shooting in the dark.

I'd much prefer that the commenting behavior be the same as in other syntaxes, where all lines that are commented out are done as single lines unless otherwise specified. I imagine this is an easy fix, I just don't know where to look.

@crucialfelix
Copy link
Owner

I think it depends on which package you use for commenting.

https://atom.io/packages/search?q=comment

The grammar identifies what a comment looks like, and then the commenting package is what makes the editor do/undo it.

Different packages have their own language support:

https://github.com/javaguirre/comment/blob/master/lib/comment.json
https://github.com/whoisthecoon/atom-block-comment-plus/blob/master/lib/languages.js

Supercollider should identify as a javascript for purposes of comments. I don't really know how to make it do that:

https://github.com/crucialfelix/atom-supercollider/blob/master/grammars/supercollider.cson

@crucialfelix
Copy link
Owner

It is definitely the comment package that determines this. Nothing I would want to do from inside atom-supercollider

This one promises to eventually support all languages:
https://atom.io/packages/multi-comment

@dyfer
Copy link

dyfer commented Aug 12, 2017

Hello,
I know this issue is closed, but is there really no solution to this? It would be very helpful to be able to use line comments. Thanks!

@woolgathering
Copy link
Contributor Author

Fixed in my fork.

@crucialfelix
Copy link
Owner

I'm checking the solution from @woolgathering

I was under the impression that it has nothing to do with the language file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants