Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

CRToastPresentationType Not Being Respected #23

Closed
cruffenach opened this Issue Feb 19, 2014 · 4 comments

Comments

Projects
None yet
2 participants
Owner

cruffenach commented Feb 19, 2014

CRToastPresentationTypePush isn't respected when kCRToastUnderStatusBarKey is YES.

Collaborator

Ashton-W commented Feb 19, 2014

Just noticed this too, I'll have a look.

Collaborator

Ashton-W commented Feb 19, 2014

You can remove CRToast.m#L779 but then you see the status bar in the push animation.

I don't know how to remove the statusbar from [[UIScreen mainScreen] snapshotViewAfterScreenUpdates:YES]]. I tried changing the frame of that view but it leaves a gap between the notification view and the navbar and breaks the effect.

Ideally the animation would be changed to start moving the navbar snapshot when the notification view hits it. Don't know how feasible that is.

Ashton-W added a commit to Ashton-W/CRToast that referenced this issue Feb 20, 2014

Collaborator

Ashton-W commented Feb 20, 2014

[window drawViewHierarchyInRect:rect afterScreenUpdates:YES]; will draw the Navigation Bar and a blank status bar area, so it appears perfect for what we needed.

Collaborator

Ashton-W commented Feb 20, 2014

Also thanks to @manolosavi, this fix comes from a discussion we had about another screenshot bug.

@cruffenach cruffenach closed this in c6f8c80 Mar 9, 2014

cruffenach added a commit that referenced this issue Mar 9, 2014

Merge pull request #25 from Ashton-W/bug/underStatusBar#23
When using underStatusBar draw statusBarView with only navigationBar. Fixes #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment