Add Button, Tooltip, and KeyListener packages #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just some small packages, in preparation for the bigger addition of `webviz-core`. Note that I opted to use `cruise-button` and `cruise-tooltip` instead of `@cruise/button` and `@cruise/tooltip`. This is to make the setup with Lerna and Webpack (when we add stories and `webviz-core`) a bit simpler. Also reran `npm run flow-typed-rebuild` to get some new definitions for the new dependencies. Test plan: verified manually that these packages work when copied over to the node_modules directory of our proprietary repo. Also made sure tests/flow/lint works.
added 5 commits
December 28, 2018 00:02
Per Jacob’s suggestions: - cruise-button => @cruise/button - cruise-tooltip => @cruise/tooltip (these required an additional line to lerna.json to have Lerna pick them up) - keylistener => react-key-listener (to make clear that it’s a React component, and we’ve been using the KeyListener capitalisation so it makes sense to translate it into lisp-case/dash-case like that).
Because @cruise was already taken. :)
jtbandes
approved these changes
Dec 28, 2018
| @@ -33,5 +34,6 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "flow-bin": "^0.89.0" | |||
| } | |||
| }, | |||
| "gitHead": "a799782ff908186f8c42c37f39806d251922ca6e" | |||
There was a problem hiding this comment.
Lerna added that automatically when publishing.
jtbandes
changed the title
Co-Authored-By: janpaul123 <janpaul123@users.noreply.github.com>
Co-Authored-By: janpaul123 <janpaul123@users.noreply.github.com>
Co-Authored-By: janpaul123 <janpaul123@users.noreply.github.com>
Co-Authored-By: janpaul123 <janpaul123@users.noreply.github.com>
Co-Authored-By: janpaul123 <janpaul123@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some small packages, in preparation for the bigger addition of
webviz-core.Also reran
npm run flow-typed-rebuildto get some new definitions forthe new dependencies.
Test plan: verified manually that these packages work when copied over
to the node_modules directory of our proprietary repo. Also made sure
tests/flow/lint works.