From efb36982e05e96ac0b17f287cfed0dbf79a46c00 Mon Sep 17 00:00:00 2001
From: "James A. Rosen" <james@zendesk.com>
Date: Sun, 13 Feb 2011 16:30:06 -0800
Subject: [PATCH] syntactic sugar for availability check [#14]

---
 README.md                                |  9 ++++---
 lib/arturo.rb                            | 33 ++++++++++++++++++------
 test/dummy_app/test/unit/feature_test.rb |  6 +++++
 3 files changed, 37 insertions(+), 11 deletions(-)

diff --git a/README.md b/README.md
index e8f31e1..ab72fb1 100644
--- a/README.md
+++ b/README.md
@@ -243,12 +243,15 @@ The latter can be used like so:
 
 If you want to check availability outside of a controller or view (really
 outside of something that has `Arturo::FeatureAvailability` mixed in), you
-can do the following:
+can ask either
 
     Arturo.feature_enabled_for?(:foo, recipient)
 
-This will check both whether the `:foo` feature exists and whether it is
-enabled for `recipient`.
+or the slightly fancier
+
+    Arturo.foo_enabled_for?(recipient)
+
+Both check whether the `foo` feature exists and is enabled for `recipient`.
 
 #### Caching
 
diff --git a/lib/arturo.rb b/lib/arturo.rb
index 162efc2..7e2e46e 100644
--- a/lib/arturo.rb
+++ b/lib/arturo.rb
@@ -6,13 +6,30 @@ module Arturo
   require 'arturo/controller_filters'
   require 'arturo/engine' if defined?(Rails) && Rails::VERSION::MAJOR == 3
 
-  # Quick check for whether a feature is enabled for a recipient.
-  # @param [String, Symbol] feature_name
-  # @param [#id] recipient
-  # @return [true,false] whether the feature exists and is enabled for the recipient
-  def self.feature_enabled_for?(feature_name, recipient)
-    f = self::Feature.to_feature(feature_name)
-    f && f.enabled_for?(recipient)
-  end
+  class <<self
+
+    # Quick check for whether a feature is enabled for a recipient.
+    # @param [String, Symbol] feature_name
+    # @param [#id] recipient
+    # @return [true,false] whether the feature exists and is enabled for the recipient
+    def feature_enabled_for?(feature_name, recipient)
+      f = self::Feature.to_feature(feature_name)
+      f && f.enabled_for?(recipient)
+    end
+
+    ENABLED_FOR_METHOD_NAME = /^(\w+)_enabled_for\?$/
 
+    def respond_to?(symbol)
+      symbol.to_s =~ ENABLED_FOR_METHOD_NAME || super(symbol)
+    end
+
+    def method_missing(symbol, *args, &block)
+      if (args.length == 1 && match = ENABLED_FOR_METHOD_NAME.match(symbol.to_s))
+        feature_enabled_for?(match[1], args[0])
+      else
+        super(symbol, *args, &block)
+      end
+    end
+
+  end
 end
diff --git a/test/dummy_app/test/unit/feature_test.rb b/test/dummy_app/test/unit/feature_test.rb
index 3d2c044..7c1b70e 100644
--- a/test/dummy_app/test/unit/feature_test.rb
+++ b/test/dummy_app/test/unit/feature_test.rb
@@ -30,6 +30,12 @@ def test_feature_enabled_for_non_existent_feature
     assert !::Arturo.feature_enabled_for?(:does_not_exist, 'Paula')
   end
 
+  def test_x_enabled_for
+    @feature = Factory(:feature, :deployment_percentage => 100, :symbol => :foo)
+    recipient = stub('User', :to_s => 'Paula', :id => 12)
+    assert ::Arturo.foo_enabled_for?(recipient), "#{feature} should be enabled for #{recipient}"
+  end
+
   def test_requires_a_symbol
     feature.symbol = nil
     assert !feature.valid?