Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Borealis integration #98

Merged
merged 10 commits into from Jan 5, 2020
Merged

Borealis integration #98

merged 10 commits into from Jan 5, 2020

Conversation

darnfish
Copy link
Contributor

@darnfish darnfish commented Jan 3, 2020

This PR uses @cryb/borealis—our new CSS framework—instead of the previous styles found inside of static/css.

Integration is still early and there are a lot of styles in static/css that aren't supported in the current version of @cryb/borealis. Here is a checklist of notable styles that aren't included.

  • Landing page

  • Menu styles

  • Modals

Working on getting these included. While looking through @cryb/web there are a lot of strange linting rules that I'm working on fixing so we have a more consistent codebase.

Thanks!

@darnfish darnfish added the enhancement New feature or request label Jan 3, 2020
@darnfish darnfish self-assigned this Jan 3, 2020
@darnfish
Copy link
Contributor Author

darnfish commented Jan 4, 2020

Borealis unfortunately undoes changes merged in #46. I'll try integrate mobile support back into Borealis before it's merged into web.

@darnfish
Copy link
Contributor Author

darnfish commented Jan 4, 2020

All styles have now been included in @cryb/borealis@0.0.5. Mobile support is still needed which I'll try work on next

@darnfish darnfish merged commit 4238176 into master Jan 5, 2020
@darnfish darnfish deleted the borealis-integration branch January 5, 2020 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant