Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core alterations in prep for Michelson backend work #174

Merged
merged 18 commits into from Nov 27, 2019

Conversation

@cwgoes
Copy link
Collaborator

cwgoes commented Nov 12, 2019

Ref #168
Ref #190

To avoid this being too much of a mega-PR, I've split off remaining work to #168 / #190.

  • Add type/usage annotated version of core (for erasure) - "HRAnn", "IRAnn"
  • Add type/usage annotated version of erased core (for backends) - "ErasedAnn"
  • Alter parameterisation typeOf to return a NonEmpty list
  • Rename some functions in typechecker to match term / elim nomenclature
  • Parameterise typechecker over a monad (no more error usage now)
  • Switch Michelson-to-Michelson optimisations to use untyped Michelson instruction representation (faster to compile & more optimisations are possible, e.g. with LAMBDA/EXEC).
@cwgoes cwgoes force-pushed the cwgoes/michelson-backend-work-contd branch from ad362d4 to 2869535 Nov 12, 2019
@cwgoes

This comment has been minimized.

Copy link
Collaborator Author

cwgoes commented Nov 23, 2019

(edit: moved elsewhere)

@cwgoes

This comment has been minimized.

Copy link
Collaborator Author

cwgoes commented Nov 23, 2019

I guess we can just create a version of erased core with type annotations (for all subterms).

@cwgoes

This comment has been minimized.

Copy link
Collaborator Author

cwgoes commented Nov 24, 2019

I guess we can just create a version of erased core with type annotations (for all subterms).

Ref #190 (comment).

@cwgoes cwgoes changed the title Michelson backend work contd. Core alterations in prep for Michelson backend work Nov 24, 2019
@cwgoes cwgoes marked this pull request as ready for review Nov 24, 2019
@cwgoes cwgoes requested a review from thealmarty Nov 24, 2019
Copy link
Contributor

thealmarty left a comment

This can be merged for now and optimize later as per #190 .

@thealmarty thealmarty merged commit 7b81fdc into develop Nov 27, 2019
2 checks passed
2 checks passed
ci/circleci: setup_dependencies Your tests passed on CircleCI!
Details
ci/circleci: test_suite Your tests passed on CircleCI!
Details
@thealmarty thealmarty deleted the cwgoes/michelson-backend-work-contd branch Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.