Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out evaluator #210

Merged
merged 3 commits into from Nov 27, 2019

Conversation

@thealmarty
Copy link
Contributor

thealmarty commented Nov 27, 2019

  • separate out evaluator from the type checker. (as per #190 comment)
  • add type checker log as per #209
thealmarty added 3 commits Nov 27, 2019
This reverts commit 6718c26.
@thealmarty thealmarty changed the title Add type checker log as per #209 Separate out evaluator Nov 27, 2019
@thealmarty

This comment has been minimized.

Copy link
Contributor Author

thealmarty commented Nov 27, 2019

Reverted the WIP of adding logging to type checker. It will be in another PR so this PR can merge first.

@thealmarty thealmarty requested a review from cwgoes Nov 27, 2019
@thealmarty thealmarty marked this pull request as ready for review Nov 27, 2019
@cwgoes
cwgoes approved these changes Nov 27, 2019
Copy link
Collaborator

cwgoes left a comment

utACK

@thealmarty thealmarty merged commit 2e89683 into develop Nov 27, 2019
2 checks passed
2 checks passed
ci/circleci: setup_dependencies Your tests passed on CircleCI!
Details
ci/circleci: test_suite Your tests passed on CircleCI!
Details
@thealmarty thealmarty deleted the thealmarty/typechecker-debugging-mode branch Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.