Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all dependencies 🌴 #12

Closed
wants to merge 1 commit into from

Conversation

greenkeeperio-bot
Copy link

Hello 👋

This is the first automated pull requests to help reach the goal of up to date and stable software.
It updates all of the dependencies in the package.json in one go, but from now on you’ll receive pull requests for each dependency update in isolation and in real time.

For updates that satisfy the existing version range you’ll get pull-requests only if it breaks your build.

Example:

-  "underscore": "^1.6.0"
+  "underscore": "^1.7.0"

When an update does not satisfy the existing range you’ll get the pull request right away.

Example:

-  "lodash": "^3.0.0"
+  "lodash": "^4.0.0"

Happy fixing and merging 🌴


This pull request was created by greenkeeper.io.
It keeps your software, up to date, all the time.

Tired of seeing this sponsor message? Upgrade to the supporter plan! You'll also get your pull requests faster ⚡

@fanatid fanatid closed this Apr 9, 2016
@fanatid fanatid deleted the greenkeeper-update-all branch April 9, 2016 07:34
@jprichardson
Copy link
Member

Eeeww no. You can't just add greenkeeper without discussing first.

@fanatid
Copy link
Contributor

fanatid commented Apr 10, 2016

sorry, removed

@dcousens
Copy link
Member

@jprichardson what's wrong with @greenkeeperio-bot? OOI.

@jprichardson
Copy link
Member

@jprichardson what's wrong with @greenkeeperio-bot? OOI.

Placing an emphasis on updating dependencies for the sake of updating dependencies doesn't seem like smart software development. To be fair, I realize Greenkeeper's premise is something along the lines that the latest dependency is the best to use (if not, why do they exist), but that's flawed.

When it comes to updating dependencies and software development, I think it's best to have human intervention (PR/issues/commits) to analyzes the merits of each upgrade. Greenkeeper removes all of this and makes people feel fuzzy that they accomplished something... because, hey, my dependencies are up to date.

Also, the Greenkeeper bot is crazy noisy.


All that being said, I could be misunderstanding the value proposition and am willing to listen to alternative viewpoints.


I just read their site a bit... I am optimistic that they can build a tool that makes it clear what's changed and that tool could then help you make the decision of whether it's a good idea to accept the PR. I don't think the current incarnation is there though.

@dcousens
Copy link
Member

I thought it only reported if a dependency broke the existing build?

@fanatid
Copy link
Contributor

fanatid commented Apr 11, 2016

I thought it only reported if a dependency broke the existing build?

no, greenkeeperio create PR every time when dependency published with new version which semver doesn't cover

@dcousens
Copy link
Member

IMHO that sounds good to me. Keeps everything moving at the right pace (its not like the merging/release process is instantaneous anyway).
I'd much prefer to have these notifications to keep my repositories up to date and avoid builds with multiple versions of the same library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants