From 2a80ff53e7c062bb5e4dfc90b79222e0553b4eda Mon Sep 17 00:00:00 2001 From: yihuang Date: Mon, 19 Sep 2022 19:37:19 +0800 Subject: [PATCH] Problem: file changes detection in workflow is problematic (backport #703) * Problem: file changes detection in workflow is problematic Solution: - fix wildcards according the plugin's doc - reformat python * fix py-lint --- .github/workflows/build.yml | 8 ++++++-- .github/workflows/linkchecker.yml | 6 ++++-- .github/workflows/lint.yml | 13 +++++++++---- .github/workflows/test.yml | 12 +++++++++--- 4 files changed, 28 insertions(+), 11 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a0bbcbe9f3..8470daee93 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -66,7 +66,9 @@ jobs: gomod2nix: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2.3.4 + - uses: actions/checkout@v3 + with: + fetch-depth: 0 - id: changed-files uses: tj-actions/changed-files@v29.0.2 with: @@ -95,7 +97,9 @@ jobs: contracts: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2.3.4 + - uses: actions/checkout@v3 + with: + fetch-depth: 0 - id: changed-files uses: tj-actions/changed-files@v29.0.2 with: diff --git a/.github/workflows/linkchecker.yml b/.github/workflows/linkchecker.yml index 84ee98639a..ab594a41be 100644 --- a/.github/workflows/linkchecker.yml +++ b/.github/workflows/linkchecker.yml @@ -11,12 +11,14 @@ jobs: markdown-link-check: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2.3.4 + - uses: actions/checkout@v3 + with: + fetch-depth: 0 - id: changed-files uses: tj-actions/changed-files@v29.0.2 with: files: | - docs/**.md + docs/**/*.md - uses: gaurav-nelson/github-action-markdown-link-check@1.0.13 if: steps.changed-files.outputs.any_changed == 'true' with: diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index fe4fc4509a..e1a68c4715 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -42,14 +42,16 @@ jobs: name: Lint python runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 + with: + fetch-depth: 0 - id: changed-files uses: tj-actions/changed-files@v29.0.2 with: files: | **/poetry.lock **/pyproject.toml - **.py + **/*.py - uses: cachix/install-nix-action@v15 if: steps.changed-files.outputs.any_changed == 'true' - uses: cachix/cachix-action@v10 @@ -63,12 +65,15 @@ jobs: name: Lint nix runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 + with: + fetch-depth: 0 - id: changed-files uses: tj-actions/changed-files@v29.0.2 with: files: | - **.nix + *.nix + **/*.nix - uses: cachix/install-nix-action@v15 if: steps.changed-files.outputs.any_changed == 'true' - run: nix-shell -I nixpkgs=./nix -p nixpkgs-fmt --run "make lint-nix" diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index e5c8cf1b41..2002d9ff70 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -16,13 +16,16 @@ jobs: integration_tests: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 + with: + fetch-depth: 0 - id: changed-files uses: tj-actions/changed-files@v29.0.2 with: files: | docs - **.md + *.md + **/*.md - uses: cachix/install-nix-action@v15 if: steps.changed-files.outputs.only_changed == 'false' - uses: cachix/cachix-action@v10 @@ -54,13 +57,16 @@ jobs: os: [macos-latest] runs-on: ${{ matrix.os }} steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 + with: + fetch-depth: 0 - id: changed-files uses: tj-actions/changed-files@v29.0.2 with: files: | docs *.md + **/*.md - uses: cachix/install-nix-action@v15 if: steps.changed-files.outputs.only_changed == 'false' - uses: cachix/cachix-action@v10