-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P&L work not correct #6
Comments
I don't follow. P&L without cost doesn't mean anything. You can't have a "loss" without taking cost into consideration. :-) The number reported here for each trade is the amount sold - amount bought - all trade/transfer fees. The total sum of all of the total unrealized P&L. There are other things that could be reported here, and if there is a useful metric to report I'd be happy to add it (but just because another site reports something in a specific way isn't a good reason, an exchange site's UI isn't a good interface for an arbitrage bot.) To give you a good idea of my thinking behind reporting this number specifically, I have been looking for metrics that allow me to monitor the profitability of the bot, in order to make changes to its code to maximize the amount of profits that it is making. |
14% in one day is impossible profit, i think without exchange cost. |
You realize that amount is in BTC not a percentage, right? |
Also please note that each trade incurs a risk, so as the bot works you may see a trade that has for example 0.04BTC loss, which would drive down the total unrealized P&L quite a lot in one shot! But 0.014 BTC for 118 trades like sounds quite reasonable performance to me. |
Need see net profit, because you pay fee to exchange to any buy/sell coins. |
The fees for the trades are taken into account as I mentioned before. |
In P&L summ in Amount and Bought without fee exchange if you add fee exchange spead will be in minus and with loss. |
OK, I think I understand what you mean now, thanks for the explanation. You are right about this. |
Actually the problem is a bit worse, we don't even take Poloniex's fees into account when simulating a trade. :-( |
1220402 should fix this, but it only takes effect for new trades unfortunately. I filed #10 for the problem described in #6 (comment). |
I think P&L worked not correct. P&L without cost on exchange (0,2%) Please included it and check same.
Impossible.
The text was updated successfully, but these errors were encountered: