-
Notifications
You must be signed in to change notification settings - Fork 41
Feature: Extend vault event documentation #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe documentation for vault events in Cryptomator was significantly expanded and reorganized. The introduction was clarified to emphasize the purpose of vault events in monitoring vault health and troubleshooting issues. The section explaining how to access and use the event view was rewritten for clarity, detailing the interface elements and event filtering options. A new section was added that thoroughly describes five specific types of vault events, explaining their causes and recommended user actions. Additional warnings and guidance were included regarding the seriousness of certain events and the importance of backups. No code or public API changes were made; only documentation was updated. Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
docs/desktop/vault-events.md (4)
18-18: Hyphenate “lower-left corner”.
According to standard style, compound modifiers like “lower-left corner” should include a hyphen.- click the **Bell** icon in the lower left corner of the main window + click the **Bell** icon in the lower-left corner of the main window🧰 Tools
🪛 LanguageTool
[uncategorized] ~18-~18: Consider adding a hyphen.
Context: ...nt view, click the Bell icon in the lower left corner of the main window. If new, unre...(TOP_LEFT_CORNER)
58-68: Refine wording and locale.
- Change “Afterwards” to the American English variant “Afterward”.
- Add Oxford comma for consistency.
- Manual intervention is required. Check file permissions, retry or free up space in the target directory. Afterwards, start the conflict resolution again by listing the decrypted directory. + Manual intervention is required. Check file permissions, retry, or free up space in the target directory. Afterward, start the conflict resolution again by listing the decrypted directory.🧰 Tools
🪛 LanguageTool
[locale-violation] ~68-~68: In American English, ‘afterward’ is the preferred variant. ‘Afterwards’ is more commonly used in British English and other dialects.
Context: ... free up space in the target directory. Afterwards, start the conflict resolution again by...(AFTERWARDS_US)
70-81: Fix grammar in remediation steps.
The condition “if there other sources” is missing a verb. This diff corrects it and trims extra space:- Restore from backup if there other sources show the same directory content . + Restore from backup if other sources show the same directory content.🧰 Tools
🪛 LanguageTool
[grammar] ~80-~80: Please check whether a verb is missing here or whether ‘there’ should be ‘their’.
Context: ...n other devices. Restore from backup if there other sources show the same directory content...(IF_THERE)
83-90: Simplify wording for directory corruption.
Replace “completely empty” with “empty” for brevity:- A *dir.c9r* file is completely empty + A *dir.c9r* file is empty🧰 Tools
🪛 LanguageTool
[style] ~87-~87: ‘completely empty’ might be wordy. Consider a shorter alternative.
Context: ...When it occurs:** - A dir.c9r file is completely empty - A dir.c9r file is larger than 1000 ...(EN_WORDINESS_PREMIUM_COMPLETELY_EMPTY)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/desktop/vault-events.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/desktop/vault-events.md
[uncategorized] ~18-~18: Consider adding a hyphen.
Context: ...nt view, click the Bell icon in the lower left corner of the main window. If new, unre...
(TOP_LEFT_CORNER)
[locale-violation] ~68-~68: In American English, ‘afterward’ is the preferred variant. ‘Afterwards’ is more commonly used in British English and other dialects.
Context: ... free up space in the target directory. Afterwards, start the conflict resolution again by...
(AFTERWARDS_US)
[grammar] ~80-~80: Please check whether a verb is missing here or whether ‘there’ should be ‘their’.
Context: ...n other devices. Restore from backup if there other sources show the same directory content...
(IF_THERE)
[style] ~87-~87: ‘completely empty’ might be wordy. Consider a shorter alternative.
Context: ...When it occurs:** - A dir.c9r file is completely empty - A dir.c9r file is larger than 1000 ...
(EN_WORDINESS_PREMIUM_COMPLETELY_EMPTY)
🔇 Additional comments (7)
docs/desktop/vault-events.md (7)
9-9: Intro: clear and informative.
The new introduction effectively explains the purpose of vault events and how they help monitor vault health.
16-16: Section heading looks good.
The "Viewing Events" heading is clear and appropriately placed.
22-24: Event view usage details are clear.
The explanation of filtering and event display elements is concise and helpful.
26-30: Event Types introduction is well structured.
The transition into listing event types is smooth and informative.
32-44: Decryption Failed Event sector is comprehensive.
The description, causes, and remediation steps are thorough and well organized.
45-56: Conflict Resolved Event section is clear.
The scenarios and recommended actions cover the necessary details.
96-96: Warning block is appropriate.
The cautionary note underscores the severity of broken file events effectively.
Added an list of possible vault events including their cause and what a user can do if they occur