Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/start date #130

Merged
merged 6 commits into from
Aug 18, 2021
Merged

Feature/start date #130

merged 6 commits into from
Aug 18, 2021

Conversation

hhamud
Copy link

@hhamud hhamud commented Aug 18, 2021

name: Pull Request
about: Create a pull request for this project
title: ''
labels: ''
assignees: ''

Description

Motivation and Context

How Has This Been Tested?

Added Unit Tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@hhamud hhamud added the enhancement New feature or request label Aug 18, 2021
@hhamud hhamud self-assigned this Aug 18, 2021
denciu
denciu approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@denciu denciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! :)

@denciu denciu mentioned this pull request Aug 18, 2021
Closed
@hhamud hhamud merged commit bf8cd2c into next Aug 18, 2021
@denciu denciu mentioned this pull request Aug 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denciu denciu denciu approved these changes

@adamazad adamazad Awaiting requested review from adamazad

@nicoelzer nicoelzer Awaiting requested review from nicoelzer

Assignees

@hhamud hhamud

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hhamud @denciu