Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next - Standardize naming convention in TemplateLauncher variables and functions #99

Merged
merged 4 commits into from
Jul 4, 2021
Merged

Next - Standardize naming convention in TemplateLauncher variables and functions #99

merged 4 commits into from
Jul 4, 2021

Conversation

adamazad
Copy link
Contributor

@adamazad adamazad commented Jul 4, 2021

Summary

  • The camcel and pascal cases for metadata are metadataUpdated and updateMetadata respectively. This PR implement these standards, also
  • Update unit tests for TemplateLauncher
  • Removes new keyword from events.

@adamazad adamazad merged commit 5ed73b7 into next Jul 4, 2021
@nicoelzer nicoelzer deleted the next-renaming branch July 4, 2021 13:40
nicoelzer
nicoelzer reviewed Jul 5, 2021
View reviewed changes
contracts/templates/TemplateLauncher.sol
string _newmetaDataContentHash
event TemplateMetadataContentHashUpdated(
address template,
string newdetaDataContentHash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newdetaDataContentHash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoelzer nicoelzer nicoelzer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamazad @nicoelzer