New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli_wallet caching issues #530

Closed
theoreticalbts opened this Issue Jan 21, 2016 · 1 comment

Comments

Projects
None yet
3 participants
@theoreticalbts
Contributor

theoreticalbts commented Jan 21, 2016

The cache design of cli_wallet is fundamentally broken, leading to numerous issues: #323 #331 #353 #527

Anything which updates the account object causes a tendency for the cache to get out of sync. Really the CLI wallet should use the same architecture as the web wallet: Subscribe to object updates in order to implement a caching proxy for all object requests from individual wallet functions. As a stop-gap we could simply remove the existing cache, implement a new cache and require it to hit the witness_node anytime it needs an account (assuming most cli_wallet users also run witness_node on localhost or a fast LAN).

As this requires a substantial re-working of the wallet, perhaps this should be a worker proposal.

@neura-sx

This comment has been minimized.

Show comment
Hide comment
@neura-sx

neura-sx Jan 22, 2016

Maybe a simple resync() command would be a good temporary fix?
This command would force the CLI's cache to be reset.
Not perfect but it still better than having to start over the whole process.

neura-sx commented Jan 22, 2016

Maybe a simple resync() command would be a good temporary fix?
This command would force the CLI's cache to be reset.
Not perfect but it still better than having to start over the whole process.

@vikramrajkumar

This comment has been minimized.

Show comment
Hide comment
@vikramrajkumar

vikramrajkumar Jan 18, 2017

Contributor

This issue was moved to bitshares/bitshares-core#151

Contributor

vikramrajkumar commented Jan 18, 2017

This issue was moved to bitshares/bitshares-core#151

@vikramrajkumar vikramrajkumar referenced this issue Jan 18, 2017

Open

cli_wallet caching issues #151

1 of 3 tasks complete

pmconrad pushed a commit to pmconrad/graphene that referenced this issue Aug 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment