Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Inner list for unwanted behaviour fixed #25

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants

stooj commented Oct 21, 2012

Added a little extra whitespace so that harassment list is a list within the main list. This was presumably the intention of the author, but they were short a single space.
Also, make file requires the build directory to exist, so added a mkdir line to the Makefile

Member

pettter commented Oct 21, 2012

Thanks! However, the build directory creation should probably be done as a separate target that the build targets then depend on. Note that combined book.md also outputs into the build directory.

stooj commented Oct 21, 2012

Looks like you are doing more sophisticated work on the Makefile than I am - what's the best course of action here? Should I rollback to 67472af and create another pull request?

Member

pettter commented Oct 22, 2012

I have to admit I'm not entirely familiar with the workflow using Github (which is why I left my own pull request unmerged), but if you could somehow either modify this pull request to provide only 467d71e, or withdraw this one and make a new one with only that..

@stooj stooj closed this Oct 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment